Remove artifacts struct and have artifact builder take a reference to output folder #263
+114
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we have this weird indirection in which we have the artifacts builder which generates the output folder, generates the artifacts and then returns an
Artifactstruct with that output folder to be used elsewhere (i.e. other stages that might require creating artifacts).To me, it feels weird that it is the artifact builder the one that owns and creates that output folder. Instead, this PR has the artifact builder to take a reference to the output folder.
Note how the tests and the main command have been simplified and look much nicer with this structure.
This PR builds on top of #262