Fix: Ensure dotnet8-env image is pushed to ghcr.io registry#430
Closed
davidchase wants to merge 7 commits intofission:masterfrom
davidchase:fix-dotnet8-env-registry-push
Closed
Fix: Ensure dotnet8-env image is pushed to ghcr.io registry#430davidchase wants to merge 7 commits intofission:masterfrom davidchase:fix-dotnet8-env-registry-push
davidchase wants to merge 7 commits intofission:masterfrom
davidchase:fix-dotnet8-env-registry-push
Conversation
The dotnet8 builder Dockerfile requires files from both the builder/ subdirectory and the parent dotnet8/ directory (Fission.DotNet.Common source files). This fix updates both Makefiles to use the parent dotnet8 directory as the Docker build context, matching the approach used by dotnet8-env-img. Changes: - dotnet8/builder/Makefile: Use parent directory as build context - dotnet8/Makefile: Use parent directory as build context for builder image This resolves the GitHub Actions build failure where files were not found. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
The dotnet8-env image was not being pushed to ghcr.io because it used 'docker build' instead of 'docker buildx build' with the DOCKER_FLAGS variable that contains --push during CI/CD. This aligns dotnet8-env with the standard build pattern used by other environments and ensures the image gets published to the registry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker buildtodocker buildx buildwith$(DOCKER_FLAGS)variableProblem
After PR #427 was merged, only
dotnet8-builderwas visible in the ghcr.io packages, butdotnet8-envwas missing.Investigation revealed that the dotnet8-env make target was using plain
docker buildcommand which only builds locally and doesn't push to the registry, even whenDOCKER_FLAGS=--pushis set in the CI environment.Solution
Updated the dotnet8-env-img target in
dotnet8/Makefileto usedocker buildx buildwith the$(DOCKER_FLAGS)variable, matching the pattern used inrules.mkand ensuring the--pushflag is properly applied during the release workflow.Test Plan