Skip to content

Conversation

@MichaelDoyle
Copy link
Member

@MichaelDoyle MichaelDoyle commented Jan 4, 2026

The behavior was changed in #3931

Checklist (if applicable):

Currently PRs have failing checks:

image

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @MichaelDoyle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a failing test in formatter_test.go. The test case TestResolveFormat was updated to correctly reflect the current behavior of the resolveFormat function, which now defaults to OutputFormatJSON when a schema is present but no specific format is given. This change ensures the test suite accurately validates the intended logic following a previous behavior modification in PR #3931.

Highlights

  • Test Correction: Corrected an erroneously failing test case in formatter_test.go that was not aligned with recent behavior changes.
  • Default Format Logic: Updated the TestResolveFormat test to assert that resolveFormat defaults to OutputFormatJSON when a schema is present but no explicit format is provided, reflecting the behavior introduced in PR fix(go/ai): fixed format resolution + prompt variants metadata #3931.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a failing test in formatter_test.go. The test for resolveFormat was updated to assert that the default format is json when a schema is present but no format is specified, which aligns with the function's implementation. The test name and assertions are now correct, and a misleading comment has been removed. The change is accurate and improves the reliability of the test suite.

@MichaelDoyle MichaelDoyle merged commit 44f4a71 into main Jan 5, 2026
6 checks passed
@MichaelDoyle MichaelDoyle deleted the go-fix-formatter-test branch January 5, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants