Skip to content

Conversation

@MichaelDoyle
Copy link
Member

It's a necessary step in pnpm v10+

Checklist (if applicable):

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @MichaelDoyle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a necessary update to the project's pnpm configuration to align with changes introduced in pnpm version 10 and above. By explicitly listing dependencies under onlyBuiltDependencies, the project ensures that essential packages can execute their postinstall build scripts, maintaining build integrity and preventing potential issues that could arise from unapproved or blocked build processes. This change is crucial for the continued smooth operation and development of the project with the updated package manager.

Highlights

  • PNPM Configuration Update: Modified the pnpm configuration in package.json files across the repository to include the onlyBuiltDependencies setting.
  • Postinstall Build Script Approval: Explicitly approved postinstall build scripts for a set of critical dependencies, including esbuild, protobufjs, @firebase/util, re2, sharp, pre-commit, and spawn-sync.
  • PNPM v10+ Compatibility: Ensured compatibility with pnpm version 10 and newer, which requires explicit approval for postinstall build scripts to run.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package.json files to be compatible with pnpm v10+ by adding the onlyBuiltDependencies field. This is a necessary security-related configuration. The changes look good, but I've identified several packages with install scripts that are missing from the onlyBuiltDependencies lists. Adding them will ensure that all required build steps are executed, preventing potential runtime issues. I've provided suggestions to update the lists in js/package.json and package.json.

@github-actions github-actions bot added go python Python labels Jan 4, 2026
@MichaelDoyle MichaelDoyle merged commit 169ffaa into main Jan 5, 2026
10 of 11 checks passed
@MichaelDoyle MichaelDoyle deleted the approve-builds branch January 5, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants