Skip to content

Conversation

@tagboola
Copy link
Contributor

@tagboola tagboola commented Dec 18, 2025

Description

Add support for specifying prerequisiteTestCaseId in test files. If specified, we'll find the corresponding test case and prepend the steps, including any prerequisite steps for that test case and so-on. If prerequisiteTestCaseId is specified and there is no test case with that ID, we'll throw an error.

Scenarios Tested

Sample Commands

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tagboola, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the app testing framework by introducing support for prerequisite test cases. This feature allows test authors to define dependencies between tests, where one test's steps are executed before another's if declared as a prerequisite. The implementation includes significant refactoring of the test parsing logic to resolve and merge these prerequisite steps recursively, ensuring proper execution order and providing robust error handling for invalid dependencies.

Highlights

  • Prerequisite Test Cases: Introduced the ability for test cases to specify a prerequisiteTestCaseId, allowing for sequential execution of test steps from dependent tests.
  • Recursive Step Merging: The test parsing logic now recursively merges steps from prerequisite test cases into the dependent test case's instructions, ensuring proper execution order.
  • Error Handling for Prerequisites: Added validation to ensure that a prerequisiteTestCaseId refers to an existing test case, throwing a FirebaseError if a non-existent ID is referenced.
  • Test Case Identification: The TestCase interface now includes an optional id field for unique identification, which is crucial for the prerequisite mechanism.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for prerequisite tests, allowing test cases to build upon one another. The implementation correctly parses and merges test steps from prerequisites. My review includes a critical fix to prevent infinite loops from circular dependencies in prerequisites and a suggestion to adjust logging levels for better user experience. I've also noted that the test suite for this new feature would benefit from a test case covering the circular dependency scenario.

@tagboola tagboola requested a review from jrothfeder December 18, 2025 16:47
@tagboola tagboola merged commit 4b7de39 into test-schema Dec 19, 2025
24 of 27 checks passed
@tagboola tagboola deleted the tagboola-prerequisite-tests branch December 19, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants