-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for prerequisite tests #9651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tagboola, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the app testing framework by introducing support for prerequisite test cases. This feature allows test authors to define dependencies between tests, where one test's steps are executed before another's if declared as a prerequisite. The implementation includes significant refactoring of the test parsing logic to resolve and merge these prerequisite steps recursively, ensuring proper execution order and providing robust error handling for invalid dependencies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for prerequisite tests, allowing test cases to build upon one another. The implementation correctly parses and merges test steps from prerequisites. My review includes a critical fix to prevent infinite loops from circular dependencies in prerequisites and a suggestion to adjust logging levels for better user experience. I've also noted that the test suite for this new feature would benefit from a test case covering the circular dependency scenario.
Description
Add support for specifying
prerequisiteTestCaseIdin test files. If specified, we'll find the corresponding test case and prepend the steps, including any prerequisite steps for that test case and so-on. IfprerequisiteTestCaseIdis specified and there is no test case with that ID, we'll throw an error.Scenarios Tested
Sample Commands