-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(ext): update TypeScript templates for ext:dev:init #9629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The default TypeScript extension template generated by `firebase ext:dev:init` was failing to build due to outdated dependencies and TypeScript configuration. This commit updates the templates to: - Bump the TypeScript version to `^5.3.0` in `package.json`. - Add `"skipLibCheck": true` to `tsconfig.json`. - Change the `firebase-functions` import to `firebase-functions/v1`. These changes ensure that newly generated TypeScript extensions build successfully without any errors.
Summary of ChangesHello @joehan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves critical build failures encountered when generating TypeScript extension templates using Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the TypeScript extension templates to resolve build failures by upgrading the TypeScript version, adding skipLibCheck: true to tsconfig.json, and updating the firebase-functions import path. The changes are correct and address the described issue. I've left one comment on the CHANGELOG.md file regarding a placeholder value and a syntax error that should be updated.
CHANGELOG.md
Outdated
|
|
||
| ### Bug Fixes | ||
|
|
||
| - **ext:** update TypeScript templates for ext:dev:init to fix build failures ([#1234](https://github.com/firebase/firebase-tools/pull/1234))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request number 1234 appears to be a placeholder. The pull request description mentions that this change fixes issue #9524. Additionally, there's a syntax error with an extra parenthesis at the end of the line. I suggest updating the line to reference the correct issue number and fix the link syntax.
| - **ext:** update TypeScript templates for ext:dev:init to fix build failures ([#1234](https://github.com/firebase/firebase-tools/pull/1234))) | |
| - **ext:** update TypeScript templates for ext:dev:init to fix build failures ([#9524](https://github.com/firebase/firebase-tools/issues/9524)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! No errors were raised when running npm run build --prefix=functions
The default TypeScript extension template generated by
firebase ext:dev:initwas failing to build due to outdated dependencies and TypeScript configuration.This commit updates the templates to:
^5.3.0inpackage.json."skipLibCheck": truetotsconfig.json.firebase-functionsimport tofirebase-functions/v1.These changes ensure that newly generated TypeScript extensions build successfully without any errors.
Fixes #9524