fix: Allow attemptDeadlineSeconds in schedule triggers #9628
Conversation
This commit updates the firebase-tools CLI to support the `attemptDeadlineSeconds` field in scheduled function triggers. This field was introduced in `firebase-functions` v7.0.1 and caused deployment failures due to schema validation errors. The following changes were made: - Updated the `ScheduleTrigger` interface in `src/deploy/functions/build.ts` and `src/deploy/functions/backend.ts` to include the `attemptDeadlineSeconds` field. - Updated the schema validation in `src/deploy/functions/runtimes/discovery/v1alpha1.ts` to allow the `attemptDeadlineSeconds` field. - Updated `src/gcp/cloudscheduler.ts` to prioritize the `attemptDeadlineSeconds` field when creating or updating Cloud Scheduler jobs. Fixes #9600
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
npm-shrinkwrap.json
Outdated
| "resolved": "https://registry.npmjs.org/@babel/core/-/core-7.19.0.tgz", | ||
| "integrity": "sha512-reM4+U7B9ss148rh2n1Qs9ASS+w94irYXga7c2jaQv9RVzpS7Mv1a9rnYYwuDa45G+DkORt9g6An2k/V4d9LbQ==", | ||
| "dev": true, | ||
| "peer": true, |
There was a problem hiding this comment.
I have reverted the changes to this file.
|
Also remove the issue-9600 file |
This commit updates the firebase-tools CLI to support the `attemptDeadlineSeconds` field in scheduled function triggers. This field was introduced in `firebase-functions` v7.0.1 and caused deployment failures due to schema validation errors. The following changes were made: - Updated the `ScheduleTrigger` interface in `src/deploy/functions/build.ts` and `src/deploy/functions/backend.ts` to include the `attemptDeadlineSeconds` field. - Updated the schema validation in `src/deploy/functions/runtimes/discovery/v1alpha1.ts` to allow the `attemptDeadlineSeconds` field. - Updated `src/gcp/cloudscheduler.ts` to prioritize the `attemptDeadlineSeconds` field when creating or updating Cloud Scheduler jobs. Fixes #9600
1 participant
Deploying functions using firebase-functions v7.0.1 fails with FirebaseError: Unexpected key 'endpoints[...].scheduleTrigger.attemptDeadlineSeconds'. This indicates that the firebase-tools CLI schema validation needs to be updated to support the attemptDeadlineSeconds field introduced in the SDK.
PR created automatically by Jules for task 7589121697635054516 started by @joehan