-
Notifications
You must be signed in to change notification settings - Fork 1.1k
update next.js integration tests #9605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @leoortizz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Next.js integration test suite to ensure its compatibility and accuracy with the latest versions of Next.js. The changes involve upgrading core Next.js dependencies, adjusting TypeScript compilation settings to leverage modern JSX transforms, and modifying the test assertions to correctly identify the file outputs and structures generated by the updated Next.js framework. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily updates the Next.js framework and its associated dependencies in the nextjs webframeworks deploy test project. Specifically, it upgrades next from 15.4.8 to 16.0.8, and updates @types/react, @types/react-dom, and eslint-config-next to align with the new Next.js version. The tsconfig.json file is modified to change the jsx compiler option from "preserve" to "react-jsx" and to include .next/dev/types/**/*.ts for development type declarations. The tests.ts file is updated to reflect changes in Next.js's output structure, including new paths for localized SSG data, the addition of _clientMiddlewareManifest.json and _not-found.html, and a significant overhaul of expected file patterns for static chunks, moving from specific names to more generic turbopack-[^.]+.js, [a-f0-9]+.js, and [a-f0-9]+.css patterns.
Description
Scenarios Tested
Sample Commands