Skip to content

feat: unite overlay implementations #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
therobrob merged 10 commits into from
Jan 3, 2026
Merged

feat: unite overlay implementations #547

therobrob merged 10 commits into from
Jan 3, 2026

Conversation

@therobrob
Copy link
Member

@therobrob therobrob commented Dec 27, 2025 •
edited
Loading

  • moved overlay handling in separate js-file
  • migrated mobileMenu overlay to the global one
  • refactored closeOverlay handling

ℹ️ i’ve decided to close all elements when clicking on the overlay. there is another option, if we wanna handle it different.
ℹ️ the use of <header> and <nav> side by side helps us with overlay-handling. For a11y it’s also okay.

Resolves #349

@github-actions
Copy link

github-actions bot commented Dec 27, 2025 •
edited by therobrob
Loading

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@netlify
Copy link

netlify bot commented Dec 27, 2025 •
edited
Loading

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 730c937
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/695992a3eccf100008f5390b
😎 Deploy Preview https://deploy-preview-547--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@therobrob therobrob marked this pull request as ready for review December 27, 2025 14:04
@therobrob therobrob added the technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. label Dec 27, 2025
@therobrob therobrob mentioned this pull request Dec 27, 2025
Merged
MoritzWeber0
MoritzWeber0 reviewed Dec 27, 2025
View reviewed changes
Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the simplification of the code base. I noticed just one small regression, which we should address.

therobrob added a commit that referenced this pull request Jan 3, 2026
@therobrob
feat: added slide-in effect for mobile nav and animated overlay (#548)
de1291e 
- added slide-in effect for mobile nav
- added transition for overlay (works also with mobile nav, when #547 is
merged)

Resolves #380
@therobrob therobrob marked this pull request as draft January 3, 2026 13:00
@therobrob therobrob marked this pull request as ready for review January 3, 2026 20:28
@therobrob therobrob requested a review from MoritzWeber0 January 3, 2026 20:28
MoritzWeber0
MoritzWeber0 previously approved these changes Jan 3, 2026
View reviewed changes
Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the border-bottom to the #header rule, otherwise the border wasn't full width. Everything else looks good, thanks!

@MoritzWeber0
Copy link
Member

MoritzWeber0 commented Jan 3, 2026

And accidentally removed the overlay styles 😄
Added them back.

@therobrob therobrob merged commit 0f3eb10 into main Jan 3, 2026
7 checks passed
@therobrob therobrob deleted the feat/349-unite-overlay-implementations branch January 3, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoritzWeber0 MoritzWeber0 MoritzWeber0 approved these changes

Assignees

No one assigned

Labels

technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unite overlay implementations

3 participants

@therobrob @MoritzWeber0