Use thread with timeout instead of setting env var in unit tests #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Went ahead and added a new env var for the connection timeout, in case 1 second isn't enough time in prod |
beauremus
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #64 by wrapping the Kafka Consumer creation logic in a thread. The
recv_timeoutmethod is then utilized to wait a limited time for the connection and abort if none can be made. This is a short-circuit of the eventual timeout that the Kafka crate would reach on its own, albeit much later than the 1 second hardcoded here.Open question: should the timeout duration be a configurable environment variable as well?