Make URLs more configurable #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob-curley-fnal
requested review from
bstover74,
mgonzal1,
rneswold and
rtadkins
Contributor
|
Should the default hosts be localhost? Are all the ports unique to allow this? |
Contributor
Author
|
@beauremus I can't see any reason not to, long term. But for now it might be best to keep them preserving the original hardcoded values, until the automated process is updated to supply the values at deploy time. |
mgonzal1
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a bunch of environment variables in place of hardcoded URLs. Created the
env_varmod to make it easier to map them to default values. Only added ones that are currently in use. Additional values can be added as additional capabilities come online.Also added a place in the README for listing out the variable names.
Resolves #60
EDIT: After talking to Mariana, she convinced me it would be easier to just combine protocol, host, and port into one variable for each service. The full URL for each will need to be provided now, not just parts of it.