Pop out a page into a new tab (like inspector in new window). DO NOT INTEGRATE

[seandenigris]

I "half" implemented it, but there are so many entry points into Coder (forClass:, forObject:, forPackage:, forCoder: - what could that last one even mean!?) that I'm not sure how to complete it, so I arbitrarily implemented the case where a class is selected (see #newPopOutButton). Maybe some double dispatch is warranted...

UPDATE: Now opens in tab instead of window.
Also, it opens in a new window because that's what inspector does, but would a new tab be better? Not sure but the advantage of the latter is that AFAICT it's easy to go from tab -> window via the UI, but not the reverse.

[seandenigris]

The last commit changed to opening in a tab instead of a window.

Outstanding questions:

1. To where can the code to open in tab be extracted? It is now duplicated between here and coder opening via tools section (see GtHomeSection>>#showSpaceWithTitle:with:from:. Namely:

   aSpace title: 'Coder'. "This is still useful because, although the title will be set even without it, it prevents a blank tab label from flashing until that happens"
   "aSpace extent: 1200@600." "This seems unneeded"
   aSpace addChild: "GtCoderStencil new" (GtCoder new"forClass: self navigationModel selectedClass") createInPager maximized .
   aSpace withHalos.
   self  showSpace: aSpace
   

2. Can Coder entry points i.e. creation methods be unified? Utilizing double dispatch would allow the above to use something like GtCoderStencil new target: MyClass and then

   GtCoder>>#for: anObject
       ^ self forCoder: anObject newClassCoder
   

   Class>>#newClassCoder
       ^ GtClassCoder forClass: self
   

   Object>>#newCoder
       ^ GtClassCoder forObject: self
   

   etc. The GtClassCoder instance creation methods could be similarly refactored, but you get the idea...
3. Should inspector be changed to pop out into a tab instead of a window? Wasn't sure if @girba's preference for tab applied there too....

[seandenigris]

Bump :) I know you're doing a Coder pass. It would be great to have this functionality. The pieces are all in this issue. @girba @syrel

[girba]

Yes, this will happen.