Do not overrid http request target url with current_request properties #2209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http processor `url` should not be manipulated by `current_request` properties. If the user code wants to inherit something from current request then they should explicitly add that property to the `url` (or custom headers) while using the `http` processor. This is an immediate fix for the following situation: An .ftd file for url /experts/?payment=true has a call to http processor like this: ```ftd -- expert-detail-response res: $processor$: pr.http method: GET url: /experts/?id=120 ``` The http processor overrides the `id` query param with the current request query params (payment=true), which is clearly wrong! The right thing is to not manipulate the user provided `url` at all. If the user want to append `payment=true` then they will have to change their ftd code so that the `url` becomes "/experts/?id=120&payment=true".
amitu
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http processor
urlshould not be manipulated bycurrent_requestproperties. If the user code wants to inherit something from current
request then they should explicitly add that property to the
url(orcustom headers) while using the
httpprocessor.This is an immediate fix for the following situation:
An .ftd file for url /experts/?payment=true has a call to http processor
like this:
The http processor overrides the
idquery param with the currentrequest query params (payment=true), which is clearly wrong! The right
thing is to not manipulate the user provided
urlat all. If the userwant to append
payment=truethen they will have to change their ftdcode so that the
urlbecomes "/experts/?id=120&payment=true".