IoBuffer: fix allocator/resource lifetime and resize/reallocate bugs #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drslebedev
had a problem deploying
to
configure coverage
GitHub Actions
Failure
drslebedev
had a problem deploying
to
configure coverage
GitHub Actions
Failure
drslebedev
had a problem deploying
to
configure coverage
GitHub Actions
Failure
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
had a problem deploying
to
configure coverage
GitHub Actions
Failure
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
RalphSteinhagen
approved these changes
Jan 14, 2026
Member
RalphSteinhagen
left a comment
RalphSteinhagen
left a comment
There was a problem hiding this comment.
Thanks for spotting and fixing this.
* Keep the same memory_resource for alloc/free to avoid alloc-dealloc mismatch (use resource()) * Correct resize() to always update _size * Fix reallocate() deallocation size (use old capacity) Signed-off-by: drslebedev <dr.s.lebedev@gmail.com>
drslebedev
force-pushed
the
fix_iobuffer_asan
branch
from
ad167af to
feb8474
Compare
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
drslebedev
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running
opendigitizerwithASanenabled, AddressSanitizer reported an issue inIoBuffer. This PR fixes that problem and also addresses two additional bugs inresize()andreallocate().IoBuffer: fix allocator/resource lifetime and resize/reallocate bugs
memory_resourcefor allocation and deallocation to avoid alloc/dealloc mismatches (resource())resize()to always update_sizereallocate()to deallocate using the old capacity