Open
Conversation
3d619e7 to
7c04d3b
Compare
7c04d3b to
4d5b835
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why ?
Stopes is used with libraries that use fairseq2:v0.5+ and needs to be upgraded to play nice with them.
It would be optimal to create a new minor release by bumping the version here, build a new release candidate and upload the wheel to PyPi.
How ?
Upgraded the code that is loaded by default when initializing the library and bumped the fairseq2 version to
>=v0.5. (42b28bb)A few additional changes were required to make the CI happy again:
RuntimeError: There is no current event loop in thread 'MainThread'. I suspect that this happened because ofpytest-asyncio>=0.15.0which changed in the past 9 months (50a9d85)RuntimeError: Dataset scripts are no longer supported. Replaced with rotten_tomatoes because it uses parquet by default. (4d5b835)Test plan
Got the CI running again.