Use prophet (1.1) instead of fbprophet (0.7)#252
Closed
inigohidalgo wants to merge 2 commits intofacebookresearch:mainfrom
Closed
Use prophet (1.1) instead of fbprophet (0.7)#252inigohidalgo wants to merge 2 commits intofacebookresearch:mainfrom
inigohidalgo wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
Author
|
Hi @iamxiaodong , I saw in #134 that you were not yet ready to merge the updated prophet dependency. Prophet has now released version 1.1 which includes a major QoL improvement, particularly for Windows users as we no longer need to install pystan, which is complicated to install without using conda. I am opening a new PR as the last one targets prophet 1.0 instead of 1.1 which is the version with this improvement, and merge conflicts have arisen since it was written. |
Merge main branch
Closed
|
Hello @inigohidalgo , any news about this PR? will there be a new release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kats
Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.
main.PR Description
I am opening this PR to upgrade prophet to 1.1 which removes the
pystandependency, which is no longer maintained: #249This would make the process of installing Kats on Windows machines 1000x more fluid, as it no longer requires users to build the prophet package themselves, and removes the necessity for installing additional C++ compilers through conda.
Ver: Kats v1.02