Skip to content

RFC: React Expressions with Implicit Do-Generator Semantics #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clemmy wants to merge 3 commits into from
Closed

RFC: React Expressions with Implicit Do-Generator Semantics #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38b4965
Update spec with jsx generation expressions
Nov 7, 2017
8747532
Add suggested changes to spec for JSX Generator Expressions
Nov 9, 2017
eeb2364
Update AST.md
clemmy Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions AST.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,21 @@ interface JSXNamespacedName <: Expression {
JSX Expression Container
------------------------

JSX adds empty "expression" type in order to allow comments in JSX text:
The expression container node contains statements with the same grammar as a generator body. Also it has a flag to indicate whether it is an expression. Any expression used as attribute value or inside JSX text should be wrapped by expression container:

```js
interface JSXEmptyExpression <: Node {
type: "JSXEmptyExpression";
interface JSXExpressionContainer <: Node {
type: "JSXExpressionContainer";
expression: Expression | JSXEmptyExpression | JSXStatementList;
isExpression: boolean;
}
```

Any expression used as attribute value or inside JSX text should is wrapped into expression container:

```js
interface JSXExpressionContainer <: Node {
type: "JSXExpressionContainer";
expression: Expression | JSXEmptyExpression;
interface JSXStatementList <: Node {
type: "JSXStatementList";
body: [ Statement ];
generator: boolean;
}
```

Expand Down
14 changes: 12 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ PrimaryExpression :

- JSXElement
- JSXFragment
- JSXGeneratorExpression

__Elements__

Expand Down Expand Up @@ -114,10 +115,19 @@ JSXAttributeValue :


- `"` JSXDoubleStringCharacters<sub>opt</sub> `"`
- `'` JSXSingleStringCharacters<sub>opt</sub> `'`
- `{` AssignmentExpression `}`
- `{` JSXGeneratorExpression `}`
- JSXElement
- JSXFragment

JSXGeneratorExpression :

- ObjectLiteral
- FunctionExpression
- ClassExpression
- GeneratorExpression
- AsyncFunctionExpression
- [lookahead &#8713; { `{` }] StatementList<sub>[+Yield]</sub>

JSXDoubleStringCharacters :


- JSXDoubleStringCharacter JSXDoubleStringCharacters<sub>opt</sub>
Expand Down Expand Up @@ -157,7 +167,7 @@ JSXTextCharacter :

JSXChildExpression :

- AssignmentExpression
- JSXGeneratorExpression
- `...` AssignmentExpression

__Whitespace and Comments__
Expand Down