Set suggested_experiment_status on generation nodes#4863
Open
CristianLara wants to merge 4 commits intofacebook:mainfrom
Open
Set suggested_experiment_status on generation nodes#4863CristianLara wants to merge 4 commits intofacebook:mainfrom
CristianLara wants to merge 4 commits intofacebook:mainfrom
Conversation
Summary: Pull Request resolved: facebook#4737 # Summary Add `ExperimentStatus` enum with phases: DRAFT, INITIALIZATION, OPTIMIZATION, COMPLETED. **Backward compatibility:** The status field defaults to `None` for existing experiments, maintaining full backward compatibility. New experiments can optionally set status as needed. Differential Revision: D86801911 Reviewed By: mgarrard
Summary: Pull Request resolved: facebook#4738 # AOSC note Land xdb schema changes first D88096914 # Summary Store ExperimentStatus on Experiment class as `status` and introduce setters/getters, update SQA classes+encoder/decoder, and add tests. Differential Revision: D90089265
Summary: This change introduces an optional `suggested_experiment_state` field to the `GenerationNode` class that allows tracking what experiment status is suggested for a given generation node. This is part of a larger effort to add status tracking to experiments. The field is: - Optional (defaults to None for backward compatibility) - Advisory only (does not automatically update experiment.status) - Configurable per GenerationNode instance - Serialized automatically via SerializationMixin - Displayed in __repr__ when set This is Phase 1 where we are just adding the column but not yet doing anything with it. In the next diffs in this stack we will propagate this through the orchestrator and eventually set this status on the experiment. Differential Revision: D88089767
Summary: Set the suggested_experiment_status field on generation nodes throughout the codebase. This allows the orchestrator to automatically update experiment status based on the optimization phase. **What changed:** 1. Updated generation_strategy_dispatch.py to set suggested_experiment_status on: - Sobol nodes (INITIALIZATION) - MBM nodes (OPTIMIZATION) 2. Updated generation_nodes.py to set suggested_experiment_status on: - Sobol nodes (INITIALIZATION) - MBM nodes (OPTIMIZATION) - PLBO nodes (OPTIMIZATION) - BOTL nodes (OPTIMIZATION) - ELC nodes (OPTIMIZATION) 3. Updated generation_strategies.py to set suggested_experiment_status on: - BOTL nodes (OPTIMIZATION) - Factorial nodes (OPTIMIZATION) - EB TS nodes (OPTIMIZATION) - Random PE nodes (INITIALIZATION) - PE nodes (OPTIMIZATION) - Various other optimization nodes (OPTIMIZATION) **Why this change:** This builds on the infrastructure added in previous diffs which added the status field to Experiment, and GenerationNode. Now we're actually setting the field on nodes so that experiments will automatically transition through their lifecycle based on what GS node they're in. Reviewed By: lena-kashtelyan, mgarrard Differential Revision: D88214256
meta-cla
bot
added
the
CLA Signed
|
@CristianLara has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88214256. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4863 +/- ##
========================================
Coverage 96.76% 96.76%
========================================
Files 589 591 +2
Lines 61832 61944 +112
========================================
+ Hits 59829 59941 +112
Misses 2003 2003 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Set the suggested_experiment_status field on generation nodes throughout the codebase. This allows the orchestrator to automatically update experiment status based on the optimization phase.
What changed:
Updated generation_strategy_dispatch.py to set suggested_experiment_status on:
Updated generation_nodes.py to set suggested_experiment_status on:
Updated generation_strategies.py to set suggested_experiment_status on:
Why this change:
This builds on the infrastructure added in previous diffs which added the status field to Experiment, and GenerationNode. Now we're actually setting the field on nodes so that experiments will automatically transition through their lifecycle based on what GS node they're in.
Reviewed By: lena-kashtelyan, mgarrard
Differential Revision: D88214256