Fix ChainedAssignmentError in warm_start_from_old_experiment#4799
Open
mgarrard wants to merge 1 commit intofacebook:mainfrom
Open
Fix ChainedAssignmentError in warm_start_from_old_experiment#4799mgarrard wants to merge 1 commit intofacebook:mainfrom
mgarrard wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
mgarrard
force-pushed
the
export-D91187974
branch
from
bfb32c5 to
f4b6157
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
…k#4799) Summary: Pandas 3.0 introduced Copy-on-Write (CoW) which makes chained assignment with `inplace=True` ineffective. The pattern `df["col"].replace(..., inplace=True)` no longer modifies the original DataFrame because the column selection creates a copy. Replace the chained `inplace=True` pattern with explicit assignment: - `df["col"].replace(..., inplace=True)` → `df["col"] = df["col"].replace(...)` This eliminates the `ChainedAssignmentError` warning and ensures the DataFrame is actually modified as intended. Differential Revision: D91187974
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4799 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 586 586
Lines 61306 61306
=======================================
Hits 59294 59294
Misses 2012 2012 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
…k#4799) Summary: Pandas 3.0 introduced Copy-on-Write (CoW) which makes chained assignment with `inplace=True` ineffective. The pattern `df["col"].replace(..., inplace=True)` no longer modifies the original DataFrame because the column selection creates a copy. Replace the chained `inplace=True` pattern with explicit assignment: - `df["col"].replace(..., inplace=True)` → `df["col"] = df["col"].replace(...)` This eliminates the `ChainedAssignmentError` warning and ensures the DataFrame is actually modified as intended. Differential Revision: D91187974
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
…k#4799) Summary: Pandas 3.0 introduced Copy-on-Write (CoW) which makes chained assignment with `inplace=True` ineffective. The pattern `df["col"].replace(..., inplace=True)` no longer modifies the original DataFrame because the column selection creates a copy. Replace the chained `inplace=True` pattern with explicit assignment: - `df["col"].replace(..., inplace=True)` → `df["col"] = df["col"].replace(...)` This eliminates the `ChainedAssignmentError` warning and ensures the DataFrame is actually modified as intended. Differential Revision: D91187974
…k#4799) Summary: Pandas 3.0 introduced Copy-on-Write (CoW) which makes chained assignment with `inplace=True` ineffective. The pattern `df["col"].replace(..., inplace=True)` no longer modifies the original DataFrame because the column selection creates a copy. Replace the chained `inplace=True` pattern with explicit assignment: - `df["col"].replace(..., inplace=True)` → `df["col"] = df["col"].replace(...)` This eliminates the `ChainedAssignmentError` warning and ensures the DataFrame is actually modified as intended. Differential Revision: D91187974
mgarrard
force-pushed
the
export-D91187974
branch
from
f4b6157 to
b7b726a
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 26, 2026
…k#4799) Summary: Pandas 3.0 introduced Copy-on-Write (CoW) which makes chained assignment with `inplace=True` ineffective. The pattern `df["col"].replace(..., inplace=True)` no longer modifies the original DataFrame because the column selection creates a copy. Replace the chained `inplace=True` pattern with explicit assignment: - `df["col"].replace(..., inplace=True)` → `df["col"] = df["col"].replace(...)` This eliminates the `ChainedAssignmentError` warning and ensures the DataFrame is actually modified as intended. Differential Revision: D91187974
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pandas 3.0 introduced Copy-on-Write (CoW) which makes chained assignment with
inplace=Trueineffective. The patterndf["col"].replace(..., inplace=True)no longer modifies the original DataFrame because the column selection creates a copy.Replace the chained
inplace=Truepattern with explicit assignment:df["col"].replace(..., inplace=True)→df["col"] = df["col"].replace(...)This eliminates the
ChainedAssignmentErrorwarning and ensures the DataFrame is actually modified as intended.Differential Revision: D91187974