fix: Fix failing tests for git message handling and init project#307
Closed
ezyang wants to merge 1 commit intogh/ezyang/228/basefrom
Closed
fix: Fix failing tests for git message handling and init project#307ezyang wants to merge 1 commit intogh/ezyang/228/basefrom
ezyang wants to merge 1 commit intogh/ezyang/228/basefrom
Conversation
This was referenced Jun 4, 2025
dmerkert
pushed a commit
to dmerkert/codemcp
that referenced
this pull request
Jun 4, 2025
These tests are failing, fix them: FAILED tests/test_git_message.py::**TestGitMessageHandling::test_append_new_metadata** - AssertionError: 'feat: Add feature\n\nDescription\n\ncodemcp-id: abc-123\n'... FAILED tests/test_git_message.py::**TestGitMessageHandling::test_meta_ignored_except_codemcp_id** - AssertionError: 'feat: Add feature\n\nother-key: value\n' != 'feat: Add fea... FAILED tests/test_git_message.py::**TestGitMessageHandling::test_single_line_subject_with_colon** - AssertionError: 'feat: Add new feature\n\ncodemcp-id: abc-123\n' != 'feat: ... FAILED e2e/test_init_project.py::**InitProjectTest::test_init_project_complex_toml** - AssertionError: 'lint' not found in "You are an AI assistant that helps use... ```git-revs 5d9c3ee (Base revision) 1795ce0 Fix append_metadata_to_message to ensure proper blank line before trailers bd3d36e Snapshot before auto-test 0f64eff Fix trailing newline issue in append_metadata_to_message 40a5d8e Add command documentation to system prompt in init_project HEAD Auto-commit lint changes ``` codemcp-id: 1-fix-fix-failing-tests-for-git-message-handling-and ghstack-source-id: f640a76 Pull-Request-resolved: ezyang#307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These tests are failing, fix them:
FAILED tests/test_git_message.py::TestGitMessageHandling::test_append_new_metadata - AssertionError: 'feat: Add feature\n\nDescription\n\ncodemcp-id: abc-123\n'...
FAILED tests/test_git_message.py::TestGitMessageHandling::test_meta_ignored_except_codemcp_id - AssertionError: 'feat: Add feature\n\nother-key: value\n' != 'feat: Add fea...
FAILED tests/test_git_message.py::TestGitMessageHandling::test_single_line_subject_with_colon - AssertionError: 'feat: Add new feature\n\ncodemcp-id: abc-123\n' != 'feat: ...
FAILED e2e/test_init_project.py::InitProjectTest::test_init_project_complex_toml - AssertionError: 'lint' not found in "You are an AI assistant that helps use...
codemcp-id: 1-fix-fix-failing-tests-for-git-message-handling-and