fix: fixing type errors in the codebase#301
Open
ezyang wants to merge 1 commit intogh/ezyang/225/basefrom
Open
fix: fixing type errors in the codebase#301ezyang wants to merge 1 commit intogh/ezyang/225/basefrom
ezyang wants to merge 1 commit intogh/ezyang/225/basefrom
Conversation
ezyang
added a commit
that referenced
this pull request
May 7, 2025
Run typecheck and fix errors. ```git-revs 182e999 (Base revision) aac2b84 Snapshot before auto-typecheck be9b500 Add type annotations to prefix and kwargs parameters 8373725 Add type annotations to signal handler parameters ba02a0c Fix import path for Claude e4d0a6a Add type annotations to replace_placeholders and process_file functions 013eb0c Add type annotations to signal handler in main.py d48136f Add type annotations to the second signal handler in main.py 4be0770 Add type arguments to generic types in write_file parameter 5df4e0e Add the Any type import to write_file.py 364c75d Fix unnecessary isinstance check in write_file.py 23eb06f Remove unused imports in agno.py a1f5ef9 Add noqa comment to _generate_command_docs function f78e27d Fix import for create_playground_endpoint 67a0e16 Update noqa comments for unused imports in main.py 610c98b Add comment explaining why isinstance check is necessary aa2c802 Fix create_playground_endpoint import path 1d0e004 Update import comments in main.py 900762f Fix isinstance check in write_file.py eae7510 Use pyright directive to disable reportUnusedImport warning 9b467f5 Add reportUnusedFunction to noqa comment 8b556f0 Fix type annotation for args parameter in run function fb5660b Add pyright directive to disable unnecessary isinstance warning eeaf4ef Fix pyright directive format in write_file.py 5b5585f Update directive for unused function in init_project.py afc68ed Rename run function to avoid redeclaration conflict 7ee6697 Fix pyright directive in write_file.py b21dd3a Add type annotation for gitignore_specs HEAD Auto-commit lint changes ``` codemcp-id: 302-fix-fixing-type-errors-in-the-codebase ghstack-source-id: 7a71a5e Pull-Request-resolved: #301
This was referenced May 7, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Run typecheck and fix errors.
codemcp-id: 302-fix-fixing-type-errors-in-the-codebase