fix: prevent errors when running formatter with no format command#285
Open
ezyang wants to merge 1 commit intogh/ezyang/211/basefrom
Open
fix: prevent errors when running formatter with no format command#285ezyang wants to merge 1 commit intogh/ezyang/211/basefrom
ezyang wants to merge 1 commit intogh/ezyang/211/basefrom
Conversation
ezyang
added a commit
that referenced
this pull request
May 4, 2025
run_formatter_without_commit should not do anything if there isn't a "format" command in codemcp.toml. Right now it seems to trigger an error. ```git-revs dffaf57 (Base revision) a2ed1d0 Fix run_formatter_without_commit to properly handle missing format command 61ebcd8 Add E2E test for run_formatter_without_commit with no format command HEAD Auto-commit lint changes ``` codemcp-id: 293-fix-prevent-errors-when-running-formatter-with-no- ghstack-source-id: 678637d Pull-Request-resolved: #285
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
run_formatter_without_commit should not do anything if there isn't a "format" command in codemcp.toml. Right now it seems to trigger an error.
codemcp-id: 293-fix-prevent-errors-when-running-formatter-with-no-