fix: improve reporting of formatted file contents to LLM#278
Open
ezyang wants to merge 2 commits intogh/ezyang/209/basefrom
Open
fix: improve reporting of formatted file contents to LLM#278ezyang wants to merge 2 commits intogh/ezyang/209/basefrom
ezyang wants to merge 2 commits intogh/ezyang/209/basefrom
Conversation
ezyang
added a commit
that referenced
this pull request
Apr 27, 2025
In the calls to run_formatter_without_commit for WriteFile, we need to be a bit more careful how we report the contents of the edited file back to the LLM. Specifically, we need to say what the file looks like POST-formatting. ```git-revs f378d7e (Base revision) 848e33b Update run_formatter_without_commit to return post-formatting file contents eb1e368 Update write_file to track post-formatting file contents e76eefa Update edit_file to track post-formatting file contents f6bcb3b Update edit_file to show post-formatting content in snippets 4335196 Update write_file to show post-formatting content snippets e184154 Clarify that edit_file snippets show post-formatting content 0f41905 Import async_open_text for asynchronous file operations HEAD Use async_open_text instead of blocking open() for file reading ``` codemcp-id: 283-fix-improve-reporting-of-formatted-file-contents-t ghstack-source-id: 2b672ad Pull-Request-resolved: #278
This was referenced Apr 27, 2025
Closed
ezyang
added a commit
that referenced
this pull request
Apr 27, 2025
In the calls to run_formatter_without_commit for WriteFile, we need to be a bit more careful how we report the contents of the edited file back to the LLM. Specifically, we need to say what the file looks like POST-formatting. ```git-revs f378d7e (Base revision) 848e33b Update run_formatter_without_commit to return post-formatting file contents eb1e368 Update write_file to track post-formatting file contents e76eefa Update edit_file to track post-formatting file contents f6bcb3b Update edit_file to show post-formatting content in snippets 4335196 Update write_file to show post-formatting content snippets e184154 Clarify that edit_file snippets show post-formatting content 0f41905 Import async_open_text for asynchronous file operations ace7796 Use async_open_text instead of blocking open() for file reading HEAD Revert edit_file.py to use the original formatter implementation ``` codemcp-id: 283-fix-improve-reporting-of-formatted-file-contents-t ghstack-source-id: 102163f Pull-Request-resolved: #278
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In the calls to run_formatter_without_commit for WriteFile, we need to be a bit more careful how we report the contents of the edited file back to the LLM. Specifically, we need to say what the file looks like POST-formatting.
codemcp-id: 283-fix-improve-reporting-of-formatted-file-contents-t