feat: use git commit hash instead of static chat id#245
Closed
ezyang wants to merge 1 commit intogh/ezyang/188/basefrom
Closed
feat: use git commit hash instead of static chat id#245ezyang wants to merge 1 commit intogh/ezyang/188/basefrom
ezyang wants to merge 1 commit intogh/ezyang/188/basefrom
Conversation
This was referenced Apr 14, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Instead of passing a single static chat id across all conversations, we're going to pass the current Git commit hash. Whenever a command returns, we will query and report what the new current commit hash is in the output. Update the system prompt to ensure that we maintain a current commit hash state and pass it / update it to all tool calls. Do NOT manually update every subtool, instead, there should be unified handling in the codemcp tool main body.
codemcp-id: 256-feat-use-git-commit-hash-instead-of-static-chat-id