fix: include template files in package installation#242
Open
ezyang wants to merge 3 commits intogh/ezyang/185/basefrom
Open
fix: include template files in package installation#242ezyang wants to merge 3 commits intogh/ezyang/185/basefrom
ezyang wants to merge 3 commits intogh/ezyang/185/basefrom
Conversation
This was referenced Apr 13, 2025
Closed
ezyang
added a commit
that referenced
this pull request
Apr 13, 2025
codemcp/templates/ contains data files that aren't Python files per se, but they need to be installed properly so that they're available to be copied when we run codemcp init. Fix pyproject.toml so that we correctly include the data files. I think I want to recursively glob everything that isn't excluded by .gitignore, but if it's best practice to directly only package things that are Git versioned that would work too (not sure how you gonna do source tarballs that way though.) ```git-revs 3f886df (Base revision) d77a938 Add Hatchling configuration to include template files in package build HEAD Auto-commit format changes ``` codemcp-id: 253-fix-include-template-files-in-package-installation ghstack-source-id: 8d5e37f Pull-Request-resolved: #242
ezyang
added a commit
that referenced
this pull request
Apr 14, 2025
codemcp/templates/ contains data files that aren't Python files per se, but they need to be installed properly so that they're available to be copied when we run codemcp init. Fix pyproject.toml so that we correctly include the data files. I think I want to recursively glob everything that isn't excluded by .gitignore, but if it's best practice to directly only package things that are Git versioned that would work too (not sure how you gonna do source tarballs that way though.) ```git-revs 3f886df (Base revision) d77a938 Add Hatchling configuration to include template files in package build 0066218 Auto-commit format changes HEAD Replace force-include with pattern-based include for template files ``` codemcp-id: 253-fix-include-template-files-in-package-installation ghstack-source-id: 5ad7eed Pull-Request-resolved: #242
ezyang
added a commit
that referenced
this pull request
Apr 14, 2025
codemcp/templates/ contains data files that aren't Python files per se, but they need to be installed properly so that they're available to be copied when we run codemcp init. Fix pyproject.toml so that we correctly include the data files. I think I want to recursively glob everything that isn't excluded by .gitignore, but if it's best practice to directly only package things that are Git versioned that would work too (not sure how you gonna do source tarballs that way though.) ```git-revs 3f886df (Base revision) d77a938 Add Hatchling configuration to include template files in package build 0066218 Auto-commit format changes b518315 Replace force-include with pattern-based include for template files HEAD Simplify package configuration to only include what's necessary ``` codemcp-id: 253-fix-include-template-files-in-package-installation ghstack-source-id: 4e685c8 Pull-Request-resolved: #242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
codemcp/templates/ contains data files that aren't Python files per se, but they need to be installed properly so that they're available to be copied when we run codemcp init. Fix pyproject.toml so that we correctly include the data files. I think I want to recursively glob everything that isn't excluded by .gitignore, but if it's best practice to directly only package things that are Git versioned that would work too (not sure how you gonna do source tarballs that way though.)
codemcp-id: 253-fix-include-template-files-in-package-installation