Closed
Conversation
This was referenced Mar 25, 2025
ezyang
added a commit
that referenced
this pull request
Mar 25, 2025
Typecheck and fix errors ```git-revs 740ffb7 (Base revision) 1c5bf9d Add missing type imports for hot_reload_entry.py 09819a1 Add type annotation for old_lines in edit_file.py 3fd6f62 Update imports in glob.py 27a8d0b Add type annotations to fix type errors in glob.py 1a60d0d Add missing type imports to grep.py d94c476 Fix type error in git_grep by ensuring matches only includes strings 4b10fea Add type annotations to fix type errors in grep_files function 0cd46c8 Add missing type imports to init_project.py ad008b3 Add type annotation for docs list in _generate_command_docs 48b3320 Add missing type imports to ls.py 1adf39e Fix type annotations in list_directory function 59f2dc7 Add type annotations to TreeNode and create_file_tree function d825571 Update type annotation in print_tree function db0b4ca Add missing type imports to read_file.py d54f11e Add type annotations to lists in read_file_content function ab254d3 Remove unused imports from hot_reload_entry.py ee0e650 Remove unused imports from glob.py 0027fcd Remove unused imports from grep.py bf54708 Fix direct dictionary assignment in grep.py 78fecc8 Remove unused imports from init_project.py 8fd1529 Remove unused imports from ls.py 18e0145 Remove unused imports from read_file.py 86fa3b5 Add back necessary imports for hot_reload_entry.py a206731 Use type cast for arguments in hot_reload_entry.py 1ba4837 Add needed type imports to edit_file.py 14215fb Fix types in apply_edit function to use capital List and Tuple from typing 2f3f6a6 Add type annotation to patch variable in apply_edit function 18d6b0a Add type annotation to output dictionary in grep_files function cef66b5 Add Dict back to imports in grep.py add8558 Change dict to Dict in render_result_for_assistant function ae26933 Add Any import to init_project.py to fix command_docs typing 7bd7079 Remove unused import in hot_reload_entry.py 3cb3d13 Remove unused imports from edit_file.py 53b0de1 Add type annotation to command_docs in init_project.py 03e0cfe Add type annotation to rules_config in init_project.py 8c77d2c Add TypeVar import to hot_reload_entry.py 4fa024b Fix imports in hot_reload_entry.py 8ec3506 Add back missing imports in hot_reload_entry.py 7620df6 Use a variable with explicit typing for arguments in hot_reload_entry.py e32127b Clean up unused imports in hot_reload_entry.py 86229d2 Add a pyright ignore comment for call_tool method in hot_reload_entry.py 1b2d5e3 Add a file-level pyright ignore directive in hot_reload_entry.py 667a67f Auto-commit format changes HEAD Auto-commit lint changes ``` codemcp-id: 229-fix-typecheck-and-fix-errors ghstack-source-id: e79d06d Pull-Request-resolved: #219
This was referenced Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Typecheck and fix errors
codemcp-id: 229-fix-typecheck-and-fix-errors