Fix: Prevent ValueError when 'std-ref' class is missing#82
Merged
Conversation
Fixes ValueError when building LaTeX/PDF output where 'std-ref' class may not be present in inline node classes. This was causing builds to fail with 'ValueError: list.remove(x): x not in list'. The fix adds a conditional check before attempting to remove the class, making the code more defensive and compatible with different Sphinx build scenarios. Fixes issue discovered in QuantEcon/continuous_time_mcs CI build: https://github.com/QuantEcon/continuous_time_mcs/actions/runs/19413054039/job/55537214078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes a error that occurs during LaTeX/PDF builds when the class is not present in inline node classes.
Error discovered in: QuantEcon/continuous_time_mcs CI build
Root Cause
In
UpdateReferencesToEnumerated.run(), the code unconditionally attempts to remove the'std-ref'class from inline node classes:During certain build scenarios (particularly LaTeX/PDF output), the
'std-ref'class may not be present in the classes list, causing the build to fail.Solution
Add a conditional check before removing the class:
This makes the code more defensive and compatible with different Sphinx build scenarios.
Testing
Impact