Fix another issue in the publish workflow#116
Merged
consideRatio merged 2 commits intoexecutablebooks:mainfrom Apr 11, 2025
Merged
Fix another issue in the publish workflow#116consideRatio merged 2 commits intoexecutablebooks:mainfrom
consideRatio merged 2 commits intoexecutablebooks:mainfrom
Conversation
Collaborator
consideRatio
commented
Apr 11, 2025
consideRatio
commented
- ci: make publish workflow functional by not calling tests.yaml workflow
- ci: stop installing not needed apt package gettext
It would be possible to fix this by adding workflow_call on the tests workflow I think, but I also know there have been some security concerns with having workflow triggers, so for now I'll remove this requirement instead. > error parsing called workflow ".github/workflows/publish.yaml" -> "./.github/workflows/tests.yaml" (source tag with sha:...) : workflow is not reusable as it is missing a `on.workflow_call` trigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.