feat: migrate from ethers.js to viem#117
feat: migrate from ethers.js to viem#117nikhilkumar1612 wants to merge 4 commits intoetherspot:masterfrom
Conversation
|
Thanks for submitting the PR. Pls can you let us know how you tested this? |
Hey i have tested my changes individully, but e2e testing is not done. Please provide me api details and sample env. |
| if(log) log.info('setting maxFeePerGas and maxPriorityFeePerGas as received') | ||
| const maxFeePerGas = ethers.utils.parseUnits(response.result.suggestBaseFee, 'gwei') | ||
| const fastGasPrice = ethers.utils.parseUnits(response.result.FastGasPrice, 'gwei') | ||
| const maxFeePerGas = parseUnits(response.result.suggestBaseFee, 9); |
There was a problem hiding this comment.
@nikhilkumar1612 create a constant value for gwei and use it allover where parseUnits of viem is called for GWEI conversion
There was a problem hiding this comment.
@nikhilkumar1612 create a constant value for gwei and use it allover where
parseUnitsof viem is called for GWEI conversion
sure 👍 @kanthgithub
|
@nikhilkumar1612 please use the latest version of viem. seems the |
hey @kanthgithub i can see 2.17.10 is the latest version, please let me know if i have to use 2.17.0 or 2.17.10 ? |
|
hey @kanthgithub are there any further changes that i have to make ? also please provide a confirm on the version of viem. |
3 participants
Description
Types of changes
What types of changes does your code introduce?
Further comments (optional)