add txn_put_get benchmark for #18667 #20953
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hwdef The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 22 files with indirect coverage changes @@ Coverage Diff @@
## main #20953 +/- ##
==========================================
- Coverage 69.20% 69.11% -0.09%
==========================================
Files 422 422
Lines 34841 34841
==========================================
- Hits 24110 24082 -28
- Misses 9330 9355 +25
- Partials 1401 1404 +3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
Contributor
Author
|
/test pull-etcd-unit-test-arm64 |
Contributor
Author
original:modified:I think the design of this benchmark case is fine, but the test results still show that the original and modified versions are the same. |
Contributor
|
/cc @ahrtr |
Signed-off-by: hwdef <hwdefcom@outlook.com>
hwdef
force-pushed
the
add-txn-benchmark
branch
from
1833b61 to
aef7d12
Compare
|
@hwdef: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #18667 #20545
This PR adds a benchmark for txn_put_get, specifically tailored for issue #18667.
Regarding the original issue, there are some existing solutions. However, we are concerned that they might impact performance. The challenge is that we currently lack a dedicated benchmark case to quantify the extent of this potential impact. Some discussions in #20545
The key to this benchmark case is to perform both the PUT and GET within a single transaction while utilizing a prefix query. This way, when there is ahrtr@76ac23f, the GET/RANGE requests can not be skipped, which degraded performance, and vice versa.
I'll attach the benchmark results shortly.
cc @siyuanfoundation @serathius @ahrtr