Insert 'epm:' text via triggers rather than in core #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For eprints/eprints3.5#219 we are adding a trigger to the bottom of `cgi/counter` (`EP_TRIGGER_CGI_COUNTER`) so bazaar can use this rather than its old hardcoded core section of `cgi/counter`. This acts the same as it did previously in `cgi/counter` with some extra hassle on the start and end to deal with `content` being a string-ref. NB: This won't work until the related core PR is merged (eprints/eprints3.5#220).
wr2f25
added a commit
to eprints/eprints3.5
that referenced
this pull request
Sep 15, 2025
This is then used to remove the custom EPM section by moving it into the bazaar ingredient (as suggested in #215). Fixes #219. NB: This will need to be rebased on top of the relevant bazaar changes (eprints/bazaar#2).
wr2f25
added a commit
to eprints/eprints3.5
that referenced
this pull request
Sep 18, 2025
This is then used to remove the custom EPM section by moving it into the bazaar ingredient (as suggested in #215). Fixes #219. NB: This will need to be rebased on top of the relevant bazaar changes (eprints/bazaar#2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For eprints/eprints3.5#219 we are adding a trigger to the bottom of
cgi/counter(EP_TRIGGER_CGI_COUNTER) so bazaar can use this rather than its old hardcoded core section ofcgi/counter.This acts the same as it did previously in
cgi/counterwith some extra hassle on the start and end to deal withcontentbeing a string-ref.NB: This won't work until the related core PR is merged (eprints/eprints3.5#220).