box_tree: always inherit clips (remove ClipBehavior)
#92
+15
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcur
force-pushed
the
always-inherit-clips
branch
3 times, most recently
from
8126b0f to
0d4555d
Compare
waywardmonkeys
approved these changes
Dec 23, 2025
Contributor
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
Approving as I think you discussed this with @no-materials ... but if he disagreed / disagrees, then let's discuss it more.
Prior to the introduction of `ClipBehavior` in #28, the old and only clipping behavior in the box tree was equivalent to `ClipBehavior::PreferLocal`, but both `ClipBehavior::PreferLocal` and `ClipBehavior::None` effectively allow children to opt out of ancestor clips, i.e. spilling out of ancestor nodes' clips. That may sometimes be useful for debugging, but is otherwise likely quite unexpected clipping behavior. Always inheriting clips simplifies clip handling (including in follow ups to this PR where clipping correctness is improved).
tomcur
force-pushed
the
always-inherit-clips
branch
from
0d4555d to
f552433
Compare
Contributor
Author
Indeed, my understanding is he agrees with this in principle (but happy to revisit otherwise). |
Contributor
Yes, as discussed, I'm aligned with this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the introduction of
ClipBehaviorin #28, the old and only clipping behavior in the box tree was equivalent toClipBehavior::PreferLocal, but bothClipBehavior::PreferLocalandClipBehavior::Noneeffectively allow children to opt out of ancestor clips, i.e. spilling out of ancestor nodes' clips. That may sometimes be useful for debugging, but is otherwise likely quite unexpected clipping behavior.Always inheriting clips simplifies clip handling (including in follow ups to this PR where clipping correctness is improved).