sequence_puzzle_object: Fix collision layers #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a static rock. The hint rocks in the sequence puzzle are SequencePuzzleHintSigns.
Previously teacher_desk.tscn had the default StaticBody2D collision_layer and collision_mask, which were then overridden in the scene where it is instantiated. Move the setting to the desk scene. Remove the collision_mask: it does not need to detect collisions, only be collided with.
Previously this object was in the "players" collision layer (the default). Instead make it a wall and a sight occluder. Unset its mask: it does not need to detect collisions, only be collided with.
Previously this used the "under bridge water" tile for the whole lake and then blocked off the bits the player shouldn't be able to cross with a StaticBody2D. Instead use the non-walkable water tile for the exposed water.
The tower should be a wall; the goblin should be an NPC. Previously they were in the "players" layer. (It doesn't really matter because they are static and the player can't reach them.)
(And rename the node.)
This is not a player; it is an NPC.
This would have made #1822 easier to diagnose.
Previously this StaticBody2D had its collision_layer and collision_mask
both set to the default, 1 (i.e. "players"). This caused the guards in
stealth_sequence_combo to detect and attack rocks, without any success.
Fix the collision_layer to 5 ("walls"), which matches the non-musical
rock, and unset collision_mask (the rock does not detect collisions).
Fix the same thing in the Champ copy of this scene.
Resolves #1822
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/sequence-puzzle-object-fix-collision-layers. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this StaticBody2D had its collision_layer and collision_mask
both set to the default, 1 (i.e. "players"). This caused the guards in
stealth_sequence_combo to detect and attack rocks, without any success.
Fix the collision_layer to 5 ("walls"), which matches the non-musical
rock, and unset collision_mask (the rock does not detect collisions).
Fix the same thing in the Champ copy of this scene.
Also fix many other objects that had default collision layers.
Resolves #1822