Credits: Move data out of scene file to CSVs & resources #1818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Play this branch at https://play.threadbare.game/branches/endlessm/credits-redux. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
force-pushed
the
credits-redux
branch
2 times, most recently
from
a9226f6 to
a990f52
Compare
Member
Author
|
@saspiers See the |
wjt
force-pushed
the
credits-redux
branch
2 times, most recently
from
fca9a22 to
a42c77e
Compare
wjt
changed the title
wjt
commented
Jan 14, 2026
Zed really wants to do this.
These are written by Godot, not humans.
Previously all the credits data was embedded into credits.tscn. This made it hard to edit. This scene also duplicated the Control structure for studios & teams within studios, which is error-prone and hard to maintain if we want to adjust margins etc. Break the Control structure up into this hierarchy: credits_list.tscn + credits_studio_view.tscn | + credits_team_view.tscn | + credits_team_view.tscn | + ... + credits_studio_view.tscn | + credits_team_view.tscn | + ... + ... Add a small addon that defines resource types for the data to populate this hierarchy, and an EditorImportPlugin to import the list of studio members from a CSV to this representation. The point of using a CSV rather than storing the data directly in a resourceis that a CSV can more easily be edited in a spreadsheet tool or text editor; I first tried using arrays of resources directly but they are very tedious to edit in Godot. Move all the credits data from the scene file to a mixture of CSVs and resources. Resolves #1782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all the credits data was embedded into credits.tscn. This made it
hard to edit.
This scene also duplicated the Control structure for studios & teams within
studios, which is error-prone and hard to maintain if we want to adjust margins
etc.
Break the Control structure up into this hierarchy:
Add a small addon that defines resource types for the data to populate this
hierarchy, and an EditorImportPlugin to import the list of studio members from a
CSV to this representation.
The point of using a CSV rather than storing the data directly in a resourceis
that a CSV can more easily be edited in a spreadsheet tool or text editor; I
first tried using arrays of resources directly but they are very tedious to edit
in Godot.
Move all the credits data from the scene file to a mixture of CSVs and
resources.
Resolves #1782