Device enhancements: derive Debug, impl Drop for Device to call Device::ungrab() on drop, add Device::is_grabbed() #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or Device; expose is_grabbed() on Device and RawDevice
coolreader18
approved these changes
Apr 1, 2025
Collaborator
coolreader18
left a comment
coolreader18
left a comment
There was a problem hiding this comment.
Seems very reasonable, thank you!
Are you sure this is necessary? In my testing the input subsystem will ungrab the device automatically when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157.
Adds
impl Drop for Deviceto callDevice::ungrab()on drop.Adds
Device::is_grabbed() -> boolandRawDevice::is_grabbed() -> boolto allow inspection of current grab state.Derives
DebugforDevice.