Skip to content

Remove html imports. Switch to including webcomponent js #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trevorgithub wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove html imports. Switch to including webcomponent js #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions dist/microfrontend1/index.html
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions dist/microfrontend2/index.html
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions dist/microfrontend3/index.html
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions microfrontend1/src/application.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@
<head>
<meta charset="UTF-8">
<title>Web components loader</title>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.1.0/webcomponents-lite.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.1.0/custom-elements-es5-adapter.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/2.4.2/webcomponents-bundle.js"></script>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous">
<link rel="import" href="angular-app.html">
<script src="main.js"></script>
</head>
<body>
<angular-app title="Angular Separate Running App"></angular-app>
Expand Down
13 changes: 2 additions & 11 deletions microfrontend1/webpack.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,11 @@
const merge = require('webpack-merge');
const common = require('./webpack.common.js');
const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');

module.exports = merge(common, {
output: {
path: path.resolve(__dirname, '../dist/microfrontend1'),
filename: '[name].[chunkhash].js'
filename: '[name].js'
},
devtool: 'source-map',
plugins: [
new HtmlWebpackPlugin({
chunks: ['main'],
filename: 'index.html',
template: path.resolve(__dirname, 'src/angular-app.html'),
inject: false
})
]
devtool: 'source-map'
});
5 changes: 2 additions & 3 deletions microfrontend2/src/application.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@
<head>
<meta charset="UTF-8">
<title>Web components loader</title>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.1.0/webcomponents-lite.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.1.0/custom-elements-es5-adapter.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/2.4.2/webcomponents-bundle.js"></script>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous">
<link rel="import" href="react-app.html">
<script src="main.js"></script>
</head>
<body>
<react-app title="React 15 Separate Running App"></react-app>
Expand Down
13 changes: 2 additions & 11 deletions microfrontend2/webpack.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,11 @@
const merge = require('webpack-merge');
const common = require('./webpack.common.js');
const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');

module.exports = merge(common, {
output: {
path: path.resolve(__dirname, '../dist/microfrontend2'),
filename: '[name].[chunkhash].js'
filename: '[name].js'
},
devtool: 'source-map',
plugins: [
new HtmlWebpackPlugin({
chunks: ['main'],
filename: 'index.html',
template: path.resolve(__dirname, 'src/react-app.html'),
inject: false
})
]
devtool: 'source-map'
});
5 changes: 2 additions & 3 deletions microfrontend3/src/application.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@
<head>
<meta charset="UTF-8">
<title>Web components loader</title>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.1.0/webcomponents-lite.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.1.0/custom-elements-es5-adapter.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/2.4.2/webcomponents-bundle.js"></script>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous">
<link rel="import" href="react-app.html">
<script src="main.js"></script>
</head>
<body>
<react-app-old title="React 0.14 Separate Running App"></react-app-old>
Expand Down
13 changes: 2 additions & 11 deletions microfrontend3/webpack.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,11 @@
const merge = require('webpack-merge');
const common = require('./webpack.common.js');
const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');

module.exports = merge(common, {
output: {
path: path.resolve(__dirname, '../dist/microfrontend3'),
filename: '[name].[chunkhash].js'
filename: '[name].js'
},
devtool: 'source-map',
plugins: [
new HtmlWebpackPlugin({
chunks: ['main'],
filename: 'index.html',
template: path.resolve(__dirname, 'src/react-app.html'),
inject: false
})
]
devtool: 'source-map'
});
9 changes: 4 additions & 5 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@
<head>
<meta charset="UTF-8">
<title>Web components loader</title>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.1.0/webcomponents-lite.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.1.0/custom-elements-es5-adapter.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/2.4.2/webcomponents-bundle.js"></script>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous">
<link rel="import" href="microfrontend1">
<link rel="import" href="microfrontend2">
<link rel="import" href="microfrontend3">
<script src="microfrontend1/main.js"></script>
<script src="microfrontend2/main.js"></script>
<script src="microfrontend3/main.js"></script>
</head>
<body>
<div id="app" class="container"></div>
Expand Down