Skip to content

embassy-executor 0.4 #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dirbaio merged 2 commits into from
Dec 6, 2023
Merged

embassy-executor 0.4 #2254

Dirbaio merged 2 commits into from
Dec 6, 2023

Conversation

@jessebraham
Copy link
Contributor

@jessebraham jessebraham commented Dec 5, 2023

Not really sure what the full release process is, but this is at least working with esp-hal. If you would like any further changes made please let me know and I'm happy to make them.

lulf
lulf approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just minor comment on the changelog

@Dirbaio
Copy link
Member

Dirbaio commented Dec 5, 2023

portable-atomic is still needed in 1.74 and 1.75, we shouldn't remove it yet. see #2242

Could you add this to changelog too? sorry I forgot

- Added an arena allocator for tasks, allowing using the `main` and `task` macros on Rust 1.75 stable. (it is only used if the `nightly` feature is not enabled. When `nightly` is enabled, `type_alias_impl_trait` is used to statically allocate tasks, as before).

@jessebraham
Copy link
Contributor Author

jessebraham commented Dec 5, 2023 •
edited
Loading

portable-atomic is still needed in 1.74 and 1.75, we shouldn't remove it yet. see #2242

Ahh my bad, wasn't aware of that issue and was just blindly following the comment in the manifest 😁

@jessebraham
Copy link
Contributor Author

jessebraham commented Dec 6, 2023 •
edited
Loading

Sorry, didn't notice that CI was red yesterday. Have updated all references to embassy-executor@0.3.x, so hopefully should be good to go here.

@Dirbaio Dirbaio added this pull request to the merge queue Dec 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2023
@Dirbaio Dirbaio added this pull request to the merge queue Dec 6, 2023
Merged via the queue into embassy-rs:main with commit ad2d904 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lulf lulf lulf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jessebraham @Dirbaio @lulf