Skip to content

Conversation

@Moosieus
Copy link

Why:

  • Follow this conversation.
  • Long story short, writing the initialization response needs to block everything thereafter to be compliant with LSP spec.
  • Mostly impacts VSCode AFAIK.

Changes:

  • Mirrors GenServer.handle_continue/2 as close as possible.
  • If applicable, waits for the principal callback's response to be written (not responded to!) to the buffer before invoking handle_continue/2.

Test branch w/ Expert available at Moosieus/expert/tree/moo/work-done-progress-handle-continue.

* Mirrors `GenServer.handle_continue/2` as close as possible.
* If applicable, waits for the principal callback's response to be written (not responded to!) to the buffer before invoking `handle_continue/2`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant