fix: ensure id always exists while handling requests

[numso]

Fix for elixir-lang/expert#116

After processing a request, we attach it to lsp.tasks by its ID. This ID is parsed within a separate Task and then sent back to the main process and received. There was at least one code path where we forgot to call send(me, {:request_id, id}) to send that ID back. This would cause the process to hang while we attempted to receive a message that would never come.

This PR assumes that every request will have an "id" key and pulls it off before starting the Task. That way we don't need to store it in the process dictionary, nor do we need to send/receive it between processes. I think that makes this code a little safer and more understandable. But if I'm missing something and you'd like this solved a different way please let me know!

[mhanberg]

Thanks for the PR!

It's okay if maybe it's too difficult, but do you think its possible to add a test for this case?

[numso]

Alright, I added a test specifically for the error case I was running into and verified that the test fails before this code change is applied. If you think other tests would be helpful let me know and I'm happy to keep going.