Conversation
- nextflow and plugin nf-ga4gh were failing to parse the JSON fields in the response from the TES server. - `Unrecognized field \"backend_parameters_strict\"` was the error message. - The solution was to add the JSON fields to the TesResources.java class.
Reviewer's Guide by SourceryThis pull request modifies the Updated class diagram for TesResourcesclassDiagram
class TesResources {
Long cpuCores
Double ramGb
Double diskGb
List~String~ zones
Map~String, String~ backendParameters
Boolean backendParametersStrict
}
note for TesResources "Added backendParameters and backendParametersStrict fields"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @trispera - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test to verify the serialization and deserialization of the new fields.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unrecognized field \"backend_parameters_strict\"was the error message.Summary by Sourcery
Bug Fixes: