Dependabot: urllib3 and boto3 updates#212
Merged
jemaltahir merged 4 commits intomasterfrom Jan 26, 2026
Merged
Conversation
Related to [tesk-core](elixir-cloud-aai/tesk-core#55)
Contributor
Reviewer's GuideUpdates container images to Alpine 3.19, modernizes Python/pip installation in Dockerfiles, relaxes and makes conditional the urllib3 and boto3 version constraints to support newer versions and multiple Python runtimes, pins moto<5 for tests, and adjusts S3-related environment variables to be compatible with newer AWS SDK checksum behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Using
--break-system-packagesin the Dockerfiles may be unnecessary (since these are isolated container images) and could mask packaging issues; consider dropping it unless there is a specific constraint that requires overriding the system Python packages. - The new
urllib3/boto3environment markers leave Python versions<3.8without an explicit constraint and treat3.8specially; it may be worth aligning these markers with the actual set of supported Python versions (e.g., viapython_requires) so dependency resolution is predictable across all intended runtimes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Using `--break-system-packages` in the Dockerfiles may be unnecessary (since these are isolated container images) and could mask packaging issues; consider dropping it unless there is a specific constraint that requires overriding the system Python packages.
- The new `urllib3`/`boto3` environment markers leave Python versions `<3.8` without an explicit constraint and treat `3.8` specially; it may be worth aligning these markers with the actual set of supported Python versions (e.g., via `python_requires`) so dependency resolution is predictable across all intended runtimes.
## Individual Comments
### Comment 1
<location> `source/tesk-core/setup.py:18-20` </location>
<code_context>
+ 'urllib3>=2.0,<3.0 ; python_version >= "3.10"',
+
+ # boto3 constraint
+ 'boto3<=1.28 ; python_version == "3.8"',
+ 'boto3>=1.28 ; python_version >= "3.9"',
]
TEST_DEPS = [ 'pytest',
</code_context>
<issue_to_address>
**suggestion (bug_risk):** The asymmetric boto3 bounds may allow future breaking changes on Python ≥3.9 without any upper limit.
For 3.8, boto3 is capped at 1.28, but for ≥3.9 it’s unbounded on the upper side, so a future boto3 major release with breaking changes would still satisfy this spec. If 1.28 is a known compatibility ceiling, consider adding a similar upper bound for ≥3.9 (e.g. `<2.0` or `<1.29`), or clarify why only 3.8 is constrained while newer Python versions are not.
```suggestion
# boto3 constraint
'boto3<=1.28 ; python_version == "3.8"',
'boto3>=1.28,<2.0 ; python_version >= "3.9"',
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
CI is broken :/ |
Member
Author
I fixed the GitHub Actions. I don't know about the readthedocs (is it new?) |
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to tesk-core this and this
Summary by Sourcery
Update container images and Python dependencies for tesk-core to support newer urllib3 and boto3 versions and align with newer Python/Alpine environments.
Enhancements:
Tests: