Conversation
wpkelso
changed the title
color09 different from bg
|
@danirabbit This might slightly change the screenshot of the custom theme dialog so you might want to hold #984 'til this is merged (or rejected). Do you have any objection to this PR? I haven't tried it yet. |
| </key> | ||
| <key name="palette" type="s"> | ||
| <default>"#073642:#dc322f:#859900:#b58900:#268bd2:#d33682:#2aa198:#eee8d5:#002b36:#dc322f:#586e75:#657b83:#839496:#6c71c4:#93a1a1:#fdf6e3"</default> | ||
| <default>"#073642:#dc322f:#859900:#b58900:#268bd2:#d33682:#2aa198:#eee8d5:#073642:#dc322f:#586e75:#657b83:#839496:#6c71c4:#93a1a1:#fdf6e3"</default> |
There was a problem hiding this comment.
Are you sure this is right? From reading the bug description it sounds like we actually need this to be much brighter. In the dark elementary theme for example this is #5e5c64 (which I'm not sure if we need to check that for contrast). It looks like maybe the better color in the solarized palette would be like base0 or base1
There was a problem hiding this comment.
Yeah, I made the same mistake as was originally done and used a literal reading of the Solarized spec. base1 probably makes the most sense to use, as we're not going to avoid conflicts no matter what we choose
3 participants
Closes #975
Solarized labels the dark mode background color as
brblack, but as it's the background, it shouldn't be used as such in context. This changesbrblackto usebase1to maintain adequate contrast.