Skip to content

SettingsPopover: use actions where possible#982

Merged
jeremypw merged 2 commits intomainfrom
lenemter/settingspopover-use-actions
Feb 3, 2026
Merged

SettingsPopover: use actions where possible#982
jeremypw merged 2 commits intomainfrom
lenemter/settingspopover-use-actions

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Feb 2, 2026

Avoids dealing with "active" property of toggle buttons

@lenemter lenemter requested a review from a team February 2, 2026 20:45
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and works as expected

@jeremypw jeremypw merged commit c254985 into main Feb 3, 2026
4 of 8 checks passed
@jeremypw jeremypw deleted the lenemter/settingspopover-use-actions branch February 3, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants