Closed
Conversation
jeremypw
changed the title
danirabbit
reviewed
Nov 11, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
I'm not a fan of this. Dialogs should be resizable, especially if they include scrollable widgets or text entries.
We also shouldn't be working around bugs like this. If there is a bug in Gala, it should be reported and fixed there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialogs are generally not intended to be resizable. The dialog can currently be set to an unreasonable size, which is persisted by the system.
This PR sets the Preferences dialog to be unresizable and then it determines its own size.