Focus terminal on enter, strip trailing spaces on doc focus out#1663
Draft
Focus terminal on enter, strip trailing spaces on doc focus out#1663
Conversation
ryonakano
reviewed
Dec 27, 2025
Member
ryonakano
left a comment
There was a problem hiding this comment.
I'm not sure if we should reuse strip-trailing-on-save setting because this is not triggered on save.
Collaborator
Author
|
@ryonakano Maybe we can rename the setting to |
Collaborator
Author
|
Regression found: The selection is lost on focussing out - this is particularly problematic when showing the context menu if you want to apply an action like change case to the selection. Converting to draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #581
It is considered potentially problematic to strip spaces on autosave so this solution is proposed. Stripping only occurs when the document is unfocused on the assumption that in that case the user is no in mid edit.
It is inconvenient to have to both move and click the pointer to focus the terminal and the same to refocus the document. Also lint errors are often caused by failing to force save the document first (trailing spaces are not stripped during autosave).