Rework word completion: Do not reparse whole document unnecessarily#1531
Closed
Rework word completion: Do not reparse whole document unnecessarily#1531
Conversation
Collaborator
Author
|
Closing - word completion PRs too old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should only be merged after the code that implements dynamic updating of the word list (by detecting insertions and deletions rather than key presses) else the word list may get out of date more often (e.g. if doc changed externally).
The document is fully parsed once on loading, editing the document does not usually require a full reparse (unless forced).
on_new_sourceviewand only call for unparsed documents