Conversation
BAProductions
changed the title
|
If you're forwarding key events there's no reason to do all that manual key press handling |
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
Is there a reason you change the copy and paste logic? Is there maybe an issue we don't know about?
Yes because my entry is set to read only |
Since entry is now in read only mode .grab_focus () & etc is no longer needed;
Remove application_instance.set_accels_for_action (ACTION_PREFIX + ACTION_CLEAR, {"Escape"});
& let event control handle it or the escape button will not animate.
Since Gdk.Key.Return is user by default to trigger the selected UI element when navigating the UI with the arrow keys or the tab keys the equal button will never get pressed or fire, But instead the highlight button will be pressed so Gdk.Key.equal makes the most since
Let me test this out |
Can test my code just so I can make sure the nothing funny happening on my end? https://gitlab.gnome.org/GNOME/gnome-calculator/-/blob/master/src/math-display.vala#L124 |
BAProductions
requested review from
danirabbit
and removed request for
lenemter
…cked function
- Exposing every single buttons like this isn't necessary & calling the for each button is a better idea EXP: activate_action(ACTION_INSERT, new GLib.Variant("s", "Character Gos Here")); is batter.
The del calc button do not use glib actions
Calling button_del_clicked(); & button_calc_clicked(); is nessary.
BAProductions
requested review from
lenemter
and removed request for
danirabbit
|
All the necessary have been made please review my code. |
BAProductions
requested review from
danirabbit
and removed request for
lenemter
|
Please be patient. You're not the only person waiting on me for a review :) |
3 participants
#242