Drop project_routing from query parameters
#5835
Open
+414
−453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawankartik-elastic
added
specification
skip-backport
Contributor
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
quux00
requested changes
Dec 11, 2025
| }, | ||
| "async_search.submit": { | ||
| "request": [ | ||
| "Request: missing json spec query parameter 'project_routing'" |
Contributor
There was a problem hiding this comment.
I don't understand what this file is reporting here.
Contributor
Author
There was a problem hiding this comment.
This is exactly why I asked you what commands you ran. I see similar changes in your PR as well, and I wasn't really sure what's all this about.
| * Supported in serverless only. | ||
| * @availability serverless stability=stable visibility=feature_flag feature_flag=serverless.cross_project.enabled | ||
| */ | ||
| project_routing?: ProjectRouting |
Contributor
There was a problem hiding this comment.
I don't see project_routing in the body for EQL or SQL, but I'm pretty sure support for them was added in the code. @luigidellaquila is that right?
If yes, @pawankartik-elastic, can you add those here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES-13725: We previously assumed that
project_routingcould appear either as a query parameter or within the request body. Now that we restrict it to just the request body, this PR makes the suitable adjustments within the specs.