Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Dec 10, 2025

Closes #5304

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Following you can find the validation changes against the target branch for the API.

API Status Request Response
inference.put_groq ➕ ⚪ Missing test Missing test

You can validate this API yourself by using the make validate target.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much red! 😮

@flobernd
Copy link
Member

Great achievement 🥳

A single CI check seems to fail.

@pquentin pquentin merged commit 18a4c3f into main Dec 12, 2025
12 checks passed
@pquentin pquentin deleted the stop-using-rest-api-spec branch December 12, 2025 06:41
@github-actions
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5831-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5831-to-8.19.

@github-actions
Copy link
Contributor

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5831-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-5831-to-9.1.

@github-actions
Copy link
Contributor

The backport to 9.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5831-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2

Then, create a pull request where the base branch is 9.2 and the compare/head branch is backport-5831-to-9.2.

@github-actions
Copy link
Contributor

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5831-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-5831-to-9.1.

@github-actions
Copy link
Contributor

The backport to 9.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5831-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2

Then, create a pull request where the base branch is 9.2 and the compare/head branch is backport-5831-to-9.2.

@github-actions
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5831-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18a4c3ff9b36e331e284b4da9c86ff24a81f0ad8
# Push it to GitHub
git push --set-upstream origin backport-5831-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5831-to-8.19.

pquentin added a commit that referenced this pull request Dec 12, 2025
* Remove reAddAvailability function

* Remove jsonSpec as a global variable

This makes it easier to spot functions that use it.

* Stop reading endpoints from jsonSpec

* Stop reading docUrl, docTag, extDocUrl, requestBodyRequired and availability from rest-api-spec

* Stop reading description and urls from rest-api-spec

* Stop validating rest-api-spec

* Stop using jsonSpec in compilation steps

* Stop using rest-api-spec altogether

* Fix compiler tests

(cherry picked from commit 18a4c3f)

# Conflicts:
#	output/schema/validation-errors.json
pquentin added a commit that referenced this pull request Dec 12, 2025
* Remove reAddAvailability function

* Remove jsonSpec as a global variable

This makes it easier to spot functions that use it.

* Stop reading endpoints from jsonSpec

* Stop reading docUrl, docTag, extDocUrl, requestBodyRequired and availability from rest-api-spec

* Stop reading description and urls from rest-api-spec

* Stop validating rest-api-spec

* Stop using jsonSpec in compilation steps

* Stop using rest-api-spec altogether

* Fix compiler tests

(cherry picked from commit 18a4c3f)

# Conflicts:
#	output/schema/validation-errors.json
@pquentin
Copy link
Member Author

💔 Some backports could not be created

Status Branch Result
9.2
9.1
8.19 Conflict resolution was aborted by the user

Manual backport

To create the backport manually run:

backport --pr 5831

Questions ?

Please refer to the Backport tool documentation

@pquentin
Copy link
Member Author

Not going to do 8.19.

pquentin added a commit that referenced this pull request Dec 12, 2025
* Remove reAddAvailability function

* Remove jsonSpec as a global variable

This makes it easier to spot functions that use it.

* Stop reading endpoints from jsonSpec

* Stop reading docUrl, docTag, extDocUrl, requestBodyRequired and availability from rest-api-spec

* Stop reading description and urls from rest-api-spec

* Stop validating rest-api-spec

* Stop using jsonSpec in compilation steps

* Stop using rest-api-spec altogether

* Fix compiler tests

(cherry picked from commit 18a4c3f)

# Conflicts:
#	output/schema/validation-errors.json
pquentin added a commit that referenced this pull request Dec 12, 2025
* Remove reAddAvailability function

* Remove jsonSpec as a global variable

This makes it easier to spot functions that use it.

* Stop reading endpoints from jsonSpec

* Stop reading docUrl, docTag, extDocUrl, requestBodyRequired and availability from rest-api-spec

* Stop reading description and urls from rest-api-spec

* Stop validating rest-api-spec

* Stop using jsonSpec in compilation steps

* Stop using rest-api-spec altogether

* Fix compiler tests

(cherry picked from commit 18a4c3f)

# Conflicts:
#	output/schema/validation-errors.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove cyclic dependency between rest-api-spec and schema.json

4 participants