Support hoisting to nearest host.#99
Merged
asakusuma merged 1 commit intoef4:masterfrom Sep 13, 2016
nathanhammond:find-host
Merged
Support hoisting to nearest host.#99asakusuma merged 1 commit intoef4:masterfrom nathanhammond:find-host
asakusuma merged 1 commit intoef4:masterfrom
nathanhammond:find-host
Conversation
Collaborator
|
@nathanhammond I presume this has been tested on past and present versions of ember-cli? I noticed that your new approach is looking for the existence of different properties than before. |
Collaborator
Author
|
|
Collaborator
|
I don't believe we want this. We need to mangle input names, and be sure we don't collide. |
Collaborator
|
@nathanhammond spoke about it, and we have come up with a solution. Going to pair on it. |
Collaborator
|
#100 is our WIP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ember-browserify currently does a one-level deep check in an attempt to find the host application, making it work in addons which directly descend from the host. This is incomplete. Addons can be nested infinitely deep and we need to recurse up to the host.
This code is extracted from Ember CLI.
Except for the one line added by ember-engines since the host is not always guaranteed to be the top level application. The host may also be the closest lazily-loaded engine.
This code is identical to the check which ember-engines uses to support importing.
Closes #92 and #93.